search

aws-robotics / kinesisvideo-common

ROS packages for facilitating the use of AWS cloud services.
Apache License 2.0
4 stars 15 forks source link

Add logging for missing region #35

Closed AAlon closed 5 years ago

AAlon commented 5 years ago

This is a fairly common issue when the config file is not loaded correctly. The lack of logging is confusing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 5 years ago

Codecov Report

Merging #35 into master will increase coverage by 0.31%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage    80.9%   81.22%   +0.31%     
==========================================
  Files          11       11              
  Lines         440      442       +2     
==========================================
+ Hits          356      359       +3     
+ Misses         84       83       -1
Flag Coverage Δ
#ROS_1 81.22% <100%> (+0.31%) :arrow_up:
#ROS_2 81.22% <100%> (+0.31%) :arrow_up:
#dashing 81.22% <100%> (+0.31%) :arrow_up:
#kinetic 81.06% <100%> (+0.31%) :arrow_up:
#melodic 81.22% <100%> (+0.31%) :arrow_up:
Impacted Files Coverage Δ
kinesis_manager/src/kinesis_stream_manager.cpp 82.18% <100%> (+0.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51d4701...aee90d6. Read the comment docs.