Improperly detecting h264_omx encoder on Ubuntu Bionic

aws-robotics / kinesisvideo-encoder-common

ROS packages for facilitating the use of AWS cloud services.

GNU Lesser General Public License v2.1

9 stars 12 forks source link

Improperly detecting h264_omx encoder on Ubuntu Bionic #2

Closed mm318 closed 5 years ago

mm318 commented 5 years ago

On Ubuntu 18.04 Bionic Beaver x86_64, I am finding that ffmpeg is indicating the "h264_omx" encoder is available even though it is not working ("libOMXCore.so" is not available), which means the h264_video_encoder node is effectively broken on Bionic Beaver x86/x64.

mm318 commented 5 years ago

By replacing avcodec_find_encoder_by_name("h264_omx") with avcodec_find_encoder(AV_CODEC_ID_H264), the behavior on Ubuntu x86/x64 will be correct, but the Raspberry Pi behavior will be to use libx264 by default instead, which is not that we want.

mm318 commented 5 years ago

Fix has been merged.