search

aws-robotics / kinesisvideo-encoder-common

ROS packages for facilitating the use of AWS cloud services.
GNU Lesser General Public License v2.1
9 stars 12 forks source link

Detection of hardware encoder is incorrect #36

Closed mm318 closed 4 years ago

mm318 commented 5 years ago

With https://github.com/aws-robotics/kinesisvideo-encoder-common/pull/35, there is an initial attempt to open the h264_omx encoder to detect whether or not it is available. However, the attempt to open it gives a message like:

[h264_video_encoder-11] [h264_omx @ 0xea8260] The encoder timebase is not set.

and fails to correctly identify that the encoder is actually there available and working.

I suspect this is because the h264_omx encoder is being attempted to be opened in is_codec_available() with unset parameters (where the timebase, or framerate, is not set as the error message above indicates).

issue-label-bot[bot] commented 5 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

ryanewel commented 5 years ago

A fix has been merged into master. Leaving this issue open until the release is available in apt

mm318 commented 4 years ago

The fix has been released to version 2.0.3.