search

aws-robotics / tts-ros1

ROS packages for facilitating text-to-speech and the use of Amazon Polly.
Apache License 2.0
19 stars 14 forks source link

integration_tests don't seem to run #37

Closed mjsobrep closed 4 years ago

mjsobrep commented 5 years ago

It appears as if the integration tests aren't being run when running colcon's test function. That seems to be causing code coverage problems. The other two test sets (test_unit_polly and test_unit_synthesizer) seem to run just fine. I don't really understand colcon enough to know why this is.

issue-label-bot[bot] commented 5 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.92. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

mm318 commented 5 years ago

Hi @mjsobrep, the integration tests weren't intended to run with colcon test, like the way the unit tests are. The integration tests never contributed to the code coverage.

There are some additional environment settings needed in order for the integration tests to run successfully. We will improve our documentation to indicate how the integration tests should be run.

mjsobrep commented 5 years ago

@mm318 I see, thanks for the clarification. I was having trouble in #36 with getting code coverage with only the unit tests. I'll have to dig deeper to figure out how to do that.

AAlon commented 4 years ago

Closing this as no further action is warranted.