aws-samples / amazon-bedrock-workshop

This is a workshop designed for Amazon Bedrock a foundational model service.
https://catalog.us-east-1.prod.workshops.aws/workshops/a4bdb007-5600-4368-81c5-ff5b4154f518/en-US/20-intro
MIT No Attribution
1.42k stars 607 forks source link

Amazon Bedrock Workshop - Possible infinite loop in In 03_Model_customization/03_continued_pretraining_titan_text.ipynb #240

Open rajavaid77 opened 5 months ago

rajavaid77 commented 5 months ago

Describe the bug A possible typo in one of cell in the Section "Check Customization Job Status"

while training_job_status == "InProgress":
    time.sleep(60)
    fine_tune_job = bedrock.get_model_customization_job(jobIdentifier=customization_job_name)["status"]
    print (training_job_status)

the loop checks for a variable value that is never altered in the loop causing indefinite loop

should be replaced with

while training_job_status == "InProgress":
    time.sleep(60)
    training_job_status = bedrock.get_model_customization_job(jobIdentifier=customization_job_name)["status"]
    print (training_job_status)