search

aws-samples / amazon-chime-react-native-demo

A React Native demo application for Android and iOS using the Amazon Chime SDK.
MIT No Attribution
102 stars 24 forks source link

[React native] - Android The video is cropped when scalingType AspectFit #121

Closed dhavalpanchani closed 2 years ago

dhavalpanchani commented 2 years ago

The video is cropped when scalingType AspectFit property is not worked in android.

dhavalpanchani commented 2 years ago

Screenshot 2022-01-06 at 7 28 33 PM

I have implemented code like this and using this property the video should be fit on the screen but it's not working as aspecting.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

hokyungh commented 2 years ago

Sorry for late reply. Would you be able to have parent view on top of DefaultRenderView and set its scaling type such as following https://github.com/aws/amazon-chime-sdk-android/blob/master/app/src/main/java/com/amazonaws/services/chime/sdkdemo/adapter/VideoAdapter.kt#L50?

dhavalpanchani commented 2 years ago

@hokyungh Could you please provide example for that because I don't have much experience in native android developer So

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ashirkhan94 commented 2 years ago

Sorry for late reply. Would you be able to have parent view on top of DefaultRenderView and set its scaling type such as following https://github.com/aws/amazon-chime-sdk-android/blob/master/app/src/main/java/com/amazonaws/services/chime/sdkdemo/adapter/VideoAdapter.kt#L50?

Same issue for me AspectFit is not work in android How to do it in react native demo app. thank you in advance