aws-samples / amazon-chime-react-native-demo

A React Native demo application for Android and iOS using the Amazon Chime SDK.
MIT No Attribution
102 stars 24 forks source link

Current demo fails to build in XCode 13.4 for iOS 15.5 #146

Closed SebassCoates closed 2 years ago

SebassCoates commented 2 years ago

Describe the bug Building for iOS 15.5 fails with XCode 13.4 after following instructions in repo.

To Reproduce Steps to reproduce the behavior:

  1. Clone repo
  2. npm install
  3. install pods
  4. npm run ios

Expected behavior Successful build

Logs The following build commands failed: CompileC /Users/sebass/Library/Developer/Xcode/DerivedData/RNDemo-ftmaypgfvaiwpwbohgtbuwewmryd/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/ReactCommon.build/Objects-normal/x86_64/RCTTurboModuleManager.o /Users/sebass/newmuto/amazon-chime-react-native-demo/node_modules/react-native/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'ReactCommon' from project 'Pods') (1 failure)

I also see this message throughout warning: Could not read serialized diagnostics file: error("Failed to open diagnostics file") (in target 'React-Core' from project 'Pods')

Test environment Info (please complete the following information):

Additional context I'm trying to chase down a crash - want to be able to reproduce in the Demo but can't build. I've tried disabling Flipper and cleaning Pods cache / Derived Data.

georgezy-amzn commented 2 years ago

Hi @SebassCoates, Thanks for reporting the issue, we'll look into it ASAP.

hokyungh commented 2 years ago

Could you try

  1. Clean in Xcode
  2. Delete Derived Data
  3. Clean Pods
  4. Rerun?
SebassCoates commented 2 years ago

@hokyungh I cleaned in XCode, deleted all the directories in Derived Data, cleaned + reinstalled pods using the following commands (CocoaPods 1.11.3)

rm -rf "${HOME}/Library/Caches/CocoaPods"
rm -rf "`pwd`/Pods/"
pod update

Re-running with npm run ios still results in a build error.

Building in XCode shows the following error, which hopefully is more helpful "No matching function for call to 'RCTBridgeModuleNameForClass'"

hokyungh commented 2 years ago

Thanks for reporting, could you try https://github.com/aws-samples/amazon-chime-react-native-demo/pull/148 for shorterm fix and see if it works?

SebassCoates commented 2 years ago

@hokyungh #148 works for me! Thanks for the quick turnaround.

I'll follow along for a more permanent fix with an updated version of React Native. We've been using code from this demo alongside a newer version of React Native, and things are working well. To prevent an iOS crash, we had to add an explicit timeout (1000ms, but experimenting with shorter) in RNVideoRenderView. Just a heads up in case you run into similar issues down the road.

hokyungh commented 2 years ago

For the crash, would you be able to open new issue with reproduction steps and logs?

SebassCoates commented 2 years ago

For the crash, would you be able to open new issue with reproduction steps and logs?

If I'm able to reproduce the crash in the demo, I'll definitely open a new issue. For now, my assumption is that it was an error in how we applied code from the demo elsewhere.

hokyungh commented 2 years ago

Feel free to open new issue if you find any problem.