aws-samples / amazon-cloudwatch-auto-alarms

Automatically create and configure Amazon CloudWatch alarms for EC2 instances, RDS, and AWS Lambda using tags for standard and custom CloudWatch Metrics.
MIT No Attribution
91 stars 85 forks source link

Fix/check sns topic arn empty str #50

Open GlennChia opened 11 months ago

GlennChia commented 11 months ago

Issue #, if available:

Description of changes:

In the CloudFormation stack, AlarmNotificationARN defaults to empty string. When passed to AlarmActions for CloudWatch Alarms, this results in the error Parameter validation failed: Invalid length for parameter AlarmActions[0], value: 0, valid min length: 1.

Fix: Check for empty string before setting AlarmActions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.