search

aws-samples / amazon-cloudwatch-container-insights

CloudWatch Agent Dockerfile and K8s YAML templates for CloudWatch Container Insights.
MIT No Attribution
164 stars 107 forks source link

Increment K8s version with agent release version with 358 for releasing CWA 1.358 #127

Closed khanhntd closed 1 year ago

khanhntd commented 1 year ago

Issue

Increment K8s version with agent release version with 358 for releasing CWA 1.358 and change the bash script since there are some bug inside it:

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

williazz commented 1 year ago

The old agent version still appears in these files

3 results - 3 files

ecs-task-definition-templates/deployment-mode/replica-service/cwagent-prometheus/cwagent-prometheus-task-definition.json:
  8        "name": "cloudwatch-agent-prometheus",
  9:       "image": "public.ecr.aws/cloudwatch-agent/cloudwatch-agent:1.247357.0b252275",
  10        "essential": true,

ecs-task-definition-templates/deployment-mode/replica-service/cwagent-prometheus/cloudformation-quickstart/cwagent-ecs-prometheus-metric-for-awsvpc.yaml:
  226          - Name: cloudwatch-agent-prometheus
  227:           Image: public.ecr.aws/cloudwatch-agent/cloudwatch-agent:1.247357.0b252275
  228            Essential: true

ecs-task-definition-templates/deployment-mode/replica-service/cwagent-prometheus/cloudformation-quickstart/cwagent-ecs-prometheus-metric-for-bridge-host.yaml:
  221          - Name: cloudwatch-agent-prometheus
  222:           Image: public.ecr.aws/cloudwatch-agent/cloudwatch-agent:1.247357.0b252275
  223            Essential: true
williazz commented 1 year ago

agent version references in k8s-yaml-templates are not be updated by the script