aws-samples / amazon-cloudwatch-container-insights

CloudWatch Agent Dockerfile and K8s YAML templates for CloudWatch Container Insights.
MIT No Attribution
163 stars 107 forks source link

Add Helm Chart support #17

Open pahud opened 4 years ago

pahud commented 4 years ago

Is the Helm Chart support in the roadmap?

I am planing to add container insights for Amazon EKS as a plugin for AWS CDK https://github.com/aws/aws-cdk/issues/7160

It would be great if we can publish container insights Helm Chart to aws/eks-charts repository. And in AWS CDK we can simply addChart() to install the container insights for Amazon EKS clusters.

hdj630 commented 4 years ago

Hi, I'd like to check with you whether addResource() in CDK works for you?

pahud commented 4 years ago

Hi @hdj630

addResource() in CDK should work, but providing a helm chart would have many benifits beyond CDK. We can deploy it in a Helm-style fashion and in some IDE such as k8slens or kubesphere we can even install/upgrade/delete the helm charts straight from the IDE.

Another benefits would be make it discoverable in Helm Hub so people can easily find it and install it just like docker hub.

We already have quite a number of listing in Helm Hub such as

https://hub.helm.sh/charts/aws/appmesh-controller https://hub.helm.sh/charts/aws/appmesh-grafana https://hub.helm.sh/charts/aws/appmesh-inject https://hub.helm.sh/charts/aws/appmesh-prometheus https://hub.helm.sh/charts/aws/appmesh-jaeger https://hub.helm.sh/charts/aws/aws-for-fluent-bit https://hub.helm.sh/charts/aws/aws-node-termination-handler https://hub.helm.sh/charts/aws/aws-vpc-cni

Would be appreciated if the container insights can be added as well.

Thoughts?

shubhamjainy commented 3 years ago

Hi, Is there any way to add container insights for Amazon EKS using AWS CDK?