search

aws-samples / amazon-cloudwatch-container-insights

CloudWatch Agent Dockerfile and K8s YAML templates for CloudWatch Container Insights.
MIT No Attribution
164 stars 107 forks source link

Always use AWS for Fluent Bit stable version #95

Closed PettitWesley closed 2 years ago

PettitWesley commented 2 years ago

Signed-off-by: Wesley Pettit wppttt@amazon.com

We should always direct customers to use the AWS for Fluent Bit stable version as it is the most likely to be free of bugs and validated by users at any given point in time: https://github.com/aws/aws-for-fluent-bit#using-the-stable-tag

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

SaxyPandaBear commented 2 years ago

Just did a cursory search in case there was something missing, and I think we want to update this YAML: https://github.com/aws-samples/amazon-cloudwatch-container-insights/blob/master/k8s-deployment-manifest-templates/deployment-mode/daemonset/container-insights-monitoring/quickstart/cwagent-fluent-bit-quickstart.yaml, as well as update our update shell script https://github.com/aws-samples/amazon-cloudwatch-container-insights/blob/master/container-insights-manifest-update.sh. The update manifest script gets called IIRC when we do a deploy of CloudWatch agent, and it looks like a deploy would override the change to stable otherwise.

PettitWesley commented 2 years ago

@SaxyPandaBear Updated

yi-yang-github commented 2 years ago

for some reason this change is showing up in master but not latest ? The AWS documents are using this link which uses the latest tag, and the fluent-bit version in there is still amazon/aws-for-fluent-bit:2.10.0 https://raw.githubusercontent.com/aws-samples/amazon-cloudwatch-container-insights/latest/k8s-deployment-manifest-templates/deployment-mode/daemonset/container-insights-monitoring/fluent-bit/fluent-bit.yaml

Also note that I upgraded k8s to 1.21 and which needs aws-for-fluent-bit:2.25 because https://github.com/aws/aws-for-fluent-bit/issues/342

SaxyPandaBear commented 2 years ago

@yi-yang-github we're in the process of releasing a new version of CloudWatch agent, and part of that release process is to update the latest tag/release for this repo, after the Docker image gets published. Once we get to that point, we will update the latest tag here to include the stable fluent-bit version. Sorry for the delay