search

aws-samples / amazon-cognito-passwordless-auth

Passwordless authentication with Amazon Cognito: FIDO2 (WebAuthn, support for Passkeys), Magic Link, SMS OTP Step Up
Apache License 2.0
382 stars 70 forks source link

Question: DefineAuth Fido2 challenge #130

Closed smnalex closed 10 months ago

smnalex commented 11 months ago

On 25 we issue a challenge if there are no sessions present, but then in the handleFido2Response 87 function we expect to have 0 sessions. Is there something that I'm missing? Thx!

ottokruse commented 10 months ago

You're right, nicely spotted. Lines 87-90 are effectively dead code and should be removed. If you're interested to send a PR?

martinpagelaws commented 10 months ago

Changes merged. Closing issue. Thanks!