LBED: zETL Opensearch lab

terhunej commented 8 months ago

Issue #, if available:

Description of changes: Added new lab for DynamoDB zero-ETL to OpenSearch integration.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tebanieo commented 8 months ago

Oh, please rebase this branch as there were additional deployments. Thanks!

amdhing commented 8 months ago

In addition to @tebanieo comments could you also add 1/ A warning note on the first page of the lab with a list of AWS services that will be used as part of this lab and an approximate of costs that may be incurred ("10s to 100s of dollars per day" will do if appropriate) if the reader were following the lab in their own AWS accounts (and not AWS provided lab accounts).

2/ A warning note on the final "Query and Conclusion" page reminding reader to delete the CFN stack and resources created as part of the lab if they were following it in their own AWS accounts. Can refer to https://catalog.workshops.aws/dynamodb-labs/en-US/game-player-data/summary for the same.

Thanks!

switch180 commented 7 months ago

Testing on WS now...

Edit: Works correctly! No permissions errors, end to end test is good. Just need to address my next comment(s)

switch180 commented 7 months ago

Changes requested. The stack took 26 minutes to launch today. This is untenable in a hands on lab situation due to the delays and extra labor this will take.

[x] Move the OS template into WS and add it to the contentspec so it is launched during provisioning. Ensure the exact same copy of the template is the one you publish in this repo - it will be rsync'd from this repo and overwrite the version in WS with each update (done manually by executing a shell script not found in source control)
[x] Update the lab guide in line with LHOL/LGME so it clearly explains the at-home versus at-aws-event options. This means you should more or less copy the lab guide sections from one of those labs, being sure that the hyperlinks are correct
[x] Resolve code comments (adding those now)

Also, I want to point out that our style guide has guidance that may affect the username that you chose. Please consider changing the username of the OS user, understanding that you will need update all related screenshots as well.

switch180 commented 7 months ago

Testing in WS. Running into failures unrelated to this lab. Will work on merging tomorrow.

terhunej commented 7 months ago

It’s PPTX

On Fri, Mar 29, 2024 at 2:09 PM Sean Shriver @.***> wrote:

@.**** commented on this pull request.

On static/images/ddb-os-zetl.png https://github.com/aws-samples/amazon-dynamodb-labs/pull/107#discussion_r1544873651 :

Can you please check in the drawio for this diagram? If it's a PPTX nvm

— Reply to this email directly, view it on GitHub https://github.com/aws-samples/amazon-dynamodb-labs/pull/107#pullrequestreview-1969608952, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVXF3XTPYLJJ66PJE5QPO3Y2XJ6ZAVCNFSM6AAAAABDZHPIZ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRZGYYDQOJVGI . You are receiving this because you authored the thread.Message ID: @.***>

aws-samples / amazon-dynamodb-labs

LBED: zETL Opensearch lab #107

@.**** commented on this pull request.