rajatchat
commented
1 month ago Yes it has been tested.
On Sat, 5 Oct 2024 at 12:50 AM, Sébastien Allamand @.***> wrote:
@.**** commented on this pull request.
In content/6-network-security/4-fully-private-cluster/1-create-cluster/index.en.md https://github.com/aws-samples/amazon-eks-security-immersion-day/pull/33#discussion_r1788204186 :
@@ -162,7 +162,7 @@ export AZ1_SUBNET=$(aws ec2 describe-subnets --filters Name=tag:aws:cloudformati export AZ2_SUBNET=$(aws ec2 describe-subnets --filters Name=tag:aws:cloudformation:stack-name,Values=eks-private-vpc Name=tag:aws:cloudformation:logical-id,Values=PrivateSubnetB Name=availability-zone,Values=${AWS_REGION}b --query "Subnets[].[SubnetId]" --output text) export AZ3_SUBNET=$(aws ec2 describe-subnets --filters Name=tag:aws:cloudformation:stack-name,Values=eks-private-vpc Name=tag:aws:cloudformation:logical-id,Values=PrivateSubnetC Name=availability-zone,Values=${AWS_REGION}c --query "Subnets[].[SubnetId]" --output text) export CLOUD9_SUBNET=$(aws ec2 describe-subnets --filters Name=tag:aws:cloudformation:stack-name,Values=eks-private-vpc Name=tag:aws:cloudformation:logical-id,Values=PrivateSubnetD Name=availability-zone,Values=${AWS_REGION}c --query "Subnets[].[SubnetId]" --output text) -export CLUSTER_VPC=$(aws ec2 describe-subnets --filters Name=tag:aws:cloudformation:stack-name,Values=eks-private-vpc Name=tag:aws:cloudformation:logical-id,Values=PrivateSubnet Name=availability-zone,Values=${AWS_REGION}c --query "Subnets[].[VpcId]" --output text) +export CLUSTER_VPC=$(aws ec2 describe-subnets --filters Name=tag:aws:cloudformation:stack-name,Values=eks-private-vpc Name=tag:aws:cloudformation:logical-id,Values=PrivateSubnet Name=availability-zone,Values=${AWS_REGION}c --query "Subnets[0].[VpcId]" --output text)
Does this change has been tested ?
— Reply to this email directly, view it on GitHub https://github.com/aws-samples/amazon-eks-security-immersion-day/pull/33#pullrequestreview-2348962690, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7VPOCGC3XNFIJ6XHMDAIDZZ3S7RAVCNFSM6AAAAABPLJHDFWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBYHE3DENRZGA . You are receiving this because you authored the thread.Message ID: <aws-samples/amazon-eks-security-immersion-day/pull/33/review/2348962690@ github.com>
allamand
Issue #, if available:
Description of changes: Update CLUSTER_VPC variable
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.