search

aws-samples / amazon-guardduty-multiaccount-scripts

This script automates the process of running the GuardDuty multi-account workflow across a group of accounts that are in your control
Apache License 2.0
130 stars 71 forks source link

Updated Failed Response Section of enableguardduty #27

Closed JamesMGerstenberg closed 5 years ago

JamesMGerstenberg commented 5 years ago

Issue When running the code with python 3.7 the Failed Account Section did not supply me with any information when in the console I can visibly see multiple accounts had Errors. After Investigation I found the issue with this which was how account.keys()[0] no longer works.

Description of changes: Update for how Python now uses Dictionaries.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ryanholland commented 5 years ago

Thanks for pointing this out, rather than nested for loops I have updated this section to cast these as list().