master_account type needs to be STR not INT on line 105 in disableguardduty.py

aws-samples / amazon-guardduty-multiaccount-scripts

This script automates the process of running the GuardDuty multi-account workflow across a group of accounts that are in your control

Apache License 2.0

130 stars 71 forks source link

master_account type needs to be STR not INT on line 105 in disableguardduty.py #35

Open christhibault opened 4 years ago

christhibault commented 4 years ago

As an INT object, master accounts that start with a zero (0) character are flagged as invalid by the check on lines 112-114, as the account length is too short.

It seems to be correct in the enableguardduty.py script on line 121.

asantos-fuze commented 4 years ago

@christhibault I've got this fixed here: https://github.com/asantos-fuze/amazon-guardduty-multiaccount-scripts/tree/fix_disable_guardduty I've the PR https://github.com/aws-samples/amazon-guardduty-multiaccount-scripts/pull/34 waiting to be merged