fix issue with guardduty events that have no severity, update low/med…

wes-novack commented 4 years ago

…ium colors

Issue #, if available: Resolves issue https://github.com/aws-samples/amazon-guardduty-to-slack/issues/22

Description of changes:

Extends the if block to skip guardduty events that have no severity, to resolve issue https://github.com/aws-samples/amazon-guardduty-to-slack/issues/22
Add logic to ensure MEDIUM severity events get processed when minSeverityLevel is set to either LOW or MEDIUM
Updates Slack notification colors so that Low are yellow, Medium are dark orange, and High remain as red

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

wes-novack commented 4 years ago

Also, can you add the "hacktoberfest" topic to this repository so that it qualifies for the https://hacktoberfest.digitalocean.com initiative that encourages open source contributions? Thanks for considering.

wes-novack commented 4 years ago

Thanks @ryanholland , did you see my question on adding a hacktoberfest topic to this repo?

ryanholland commented 4 years ago

Yes I did, I will check with our open source team. thanks ryan

wes-novack commented 4 years ago

@ryanholland looks like if you add the hacktoberfest-accepted to this PR, that will make it qualify as well. If that's easier for you...

aws-samples / amazon-guardduty-to-slack

fix issue with guardduty events that have no severity, update low/med… #23