aws-samples / amazon-ivs-broadcast-android-sample

MIT No Attribution
9 stars 8 forks source link

setDefaultAspectMode for video in broadcastconfiguration is not public #2

Closed 3embed007 closed 2 years ago

3embed007 commented 2 years ago

Hi was trying to set the aspect ration of video to FILL instead of fit,but that methos seems to be private in code for sdk version 1.0.0,can you please help me? Although as per docs,this method is public.

Screen Shot 2021-09-01 at 6 36 29 PM
caleighm commented 2 years ago

Hi there! Thanks for reporting this issue. That API will be made public in an upcoming release. In the meantime, we'll update our documentation so it's less confusing.

3embed007 commented 2 years ago

Ok thanks for the prompt reply, any idea when is the next release scheduled?

caleighm commented 2 years ago

Hi @3embed007 , I can't give exact details on when upcoming releases are scheduled, but this issue is definitely on our radar.

In the meantime, to unblock you, you might try modifying the slot's aspect mode instead of the video. If you're using a full-screen slot, that will actually end up with an identical effect.

3embed007 commented 2 years ago

Hi, thanks for the suggestion, i have tried adding slot.setAspect(BroadcastConfiguration.AspectMode.FILL); for a full-screen slot and using broadcastSession.attachDevice(... as per the docs, still the video for me is showing black band on top and bottom on some devices.Basically i'am trying to resolve this issue,when on some devices camera output is not fitting to fullscreen using fill aspect mode, and this issue is therein above sample app also,any help or guidance on how to achieve it shall be highly appreciated.Thanks

3embed007 commented 2 years ago

Hi,i was able to resolve that issue, by adding this line---

ImagePreviewView preview = ((ImageDevice) device).getPreviewView(BroadcastConfiguration.AspectMode.FILL); Thanks.

caleighm commented 2 years ago

Great! Glad you were able to resolve this. I will close this issue, but please let us know if you have more questions!