search

aws-samples / amazon-ivs-broadcast-for-android-demo

This repository contains a broadcasting application for Android. The app is built on Amazon IVS and uses the Amazon IVS Broadcast SDK to stream video from an Android device to an Amazon IVS channel.
MIT No Attribution
10 stars 4 forks source link

Moved broadcast logic to BroadcastManager.kt #3

Closed egorbunovs closed 2 years ago

egorbunovs commented 2 years ago

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

slee-aws commented 2 years ago

The app still freezes for me with the latest update. I can partially reproduce it on a Galaxy S10 with the following steps:

At this point, the app UI becomes unresponsive and the camera shows a black screen. This doesn't seem to happen 100% of the time however, so I'm trying to come up with better steps to reproduce.

egorbunovs commented 2 years ago

I have a Galaxy S10 and haven't noticed any freezes with the latest code in this branch. Could you please re-verify if that's the same for you @slee-aws ? :)

slee-aws commented 2 years ago

The changes are working for me now. LGTM - will merge and close this PR. Thank you for the contribution!