search

aws-samples / amazon-kinesis-video-streams-media-interface

Amazon Kinesis Video Streams Media Interface provides abstract interfaces for board specific media APIs. This repository also contains boards sensors/encoder implementations for Amazon Kinesis Video Streams Producer and WebRTC with out-of-box samples.
Apache License 2.0
32 stars 24 forks source link

Fix compile error on Linux x86. #109

Closed chenln1124 closed 1 year ago

chenln1124 commented 1 year ago

When compiling libwebsockets, libcap will be checked. If libcap is already installed on the system, it will be linked to libwebsockets. Therefore, kvswebrtcmaster also needs link libcap, otherwise will meet compile error.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codingspirit commented 1 year ago

LWS already contains code in CMake to check libcap: https://github.com/warmcat/libwebsockets/blob/f9d1f25abe896b9fa1de780e4a5cb41116926a29/CMakeLists.txt#L716

I don't think it's necessary to do that check again in media interface. Can you provide the whole build error message for further investigation?