aws-samples / amazon-kinesis-video-streams-media-interface

Amazon Kinesis Video Streams Media Interface provides abstract interfaces for board specific media APIs. This repository also contains boards sensors/encoder implementations for Amazon Kinesis Video Streams Producer and WebRTC with out-of-box samples.
Apache License 2.0
32 stars 24 forks source link

Duplicate declaration of const? #99

Closed cwestergren closed 1 year ago

cwestergren commented 1 year ago

Describe the build issue Some code seems to include duplicate const declaration like;

VideoCapturerStatus videoCapturerGetStatus(const VideoCapturerHandle const handle) { if (!handle) { return VID_CAP_STATUS_NOT_READY; }

FILE_HANDLE_GET(handle);
return fileHandle->status;

}

Target platform Linux

Commit id The commit id you are using. 47c3e59d9d14df0be7e8532279646c7a63c5b6de

codingspirit commented 1 year ago

@cwestergren It indicates that the pointer and the value it points to should not be modified. It's reasonable to do so in a get method because we don't want handle modified inside get function call.

Please let me know if your compiler is complaining about this.

codingspirit commented 1 year ago

Closing stale issue.

cwestergren commented 1 year ago

@codingspirit sorry for delay on this response, good that you closed the issue. I had an environment issue causing this build error. Solved now.

codingspirit commented 1 year ago

@cwestergren We decide to remove the second const qualifier since c++ toolchains complain about this. See #101 for more details

cwestergren commented 1 year ago

Thank you, understood. Made this changes locally in my trials, and will have a look at #101.