aws-samples / amazon-kinesis-video-streams-producer-embedded-c

Light-wight Amazon Kinesis Video Streams Producer SDK For FreeRTOS/Embedded Linux
Apache License 2.0
27 stars 17 forks source link

[QUESTION] How to send an end of fragment frame? #48

Closed gtapizquent closed 2 years ago

gtapizquent commented 2 years ago

Other libraries like https://github.com/awslabs/amazon-kinesis-video-streams-producer-c support sending end of fragment frames. But I do not see any method that readily does this.

How can this be done?

weichihl commented 2 years ago

I assume the end of fragment frames means the frames that haven't been sent out when it's about to terminate the connection. It can be done by checking stream buffer status and sending it out. However, there is no such feature in the sample "KvsApp," and I think it's worth adding it.

I'll add an enhancement tag and plan to add this feature if it sounds good to you.

weichihl commented 2 years ago

@gtapizquent I've completed this feature in PR #50. Please let me know if there are any issues or features that need our help so that we can implement them in advance. Thanks.

gtapizquent commented 2 years ago

@weichihl Perfect. I will give this a try. You can consider the issue closed.