Closed rstrahan closed 9 months ago
I pulled the branch locally and ran the following:
./deploy.sh
this ran successfully and updated my CF stack but after the deployment the bot was broken, the reason behind this is that all API GW returned HTTP 500. I fixed it manually by going into each API and just reapply the function which triggered a pop up to provide permission to API GW to call this function (see here), and then I deployed it to Prod
stage. We might want to investigate this, as there was no change related to API GW in your PR but due to the function name changed, then permissions were updated. ./publish.sh
ran successfully and output the CF Launch URL which opened the console with the appropriate parameters - nice work on the output parametersI think we should inquired what happened in the deploy script and also document (per my comment above) who should use ./publish.sh
.
Follow up question: Should we publish in the source a generated Cfn template for people to use (if they don't want to checkout the repo and do everything manually)?
Thanks!
@gbenattar Ready for another review.. This addresses your comments, and has README changes. Main README assumes use of pre-built published templates (try it).. There's a separate README_DEVELOPERS that explains how to use the deploy.sh and publish.sh scripts to deploy / publish from source code.
Great - two READMEs make sense and the main one with the launch buttons is a significant improvement for adoption.
LGTM ! Ship it! (modulo conflicts on README.md)
Issue #, if available:
Description of changes:
To publish CFn templates, run:
The template will be published to bucket:-/.
Assets will be published to: -//
Template URLs are output by the script.
TODO: Update README to explain how and why to use the publish.sh script, and include links to templates we will publish to public S3 buckets.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.