aws-samples / amazon-q-slack-gateway

MIT No Attribution
79 stars 28 forks source link

Enable option for stack deployment using CloudFormation with no dependency on dev shell, cdk, etc. #20

Closed rstrahan closed 9 months ago

rstrahan commented 9 months ago

Issue #, if available:

Description of changes:

To publish CFn templates, run:

./publish.sh <bucket-basename> <prefix> <region> [public]

The template will be published to bucket: -/. Assets will be published to: -// Template URLs are output by the script.

TODO: Update README to explain how and why to use the publish.sh script, and include links to templates we will publish to public S3 buckets.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

gbenattar commented 9 months ago

I pulled the branch locally and ran the following:

I think we should inquired what happened in the deploy script and also document (per my comment above) who should use ./publish.sh.

Follow up question: Should we publish in the source a generated Cfn template for people to use (if they don't want to checkout the repo and do everything manually)?

Thanks!

rstrahan commented 9 months ago

@gbenattar Ready for another review.. This addresses your comments, and has README changes. Main README assumes use of pre-built published templates (try it).. There's a separate README_DEVELOPERS that explains how to use the deploy.sh and publish.sh scripts to deploy / publish from source code.

gbenattar commented 9 months ago

Great - two READMEs make sense and the main one with the launch buttons is a significant improvement for adoption.

LGTM ! Ship it! (modulo conflicts on README.md)