search

aws-samples / amazon-q-slack-gateway

MIT No Attribution
79 stars 28 forks source link

IAM IdC cross-region support #60

Closed james-jory closed 1 day ago

james-jory commented 1 week ago

Issue #, if available:

Closes #59

Description of changes:

Added deployment option to specify the IAM IdC region used by the gateway when making API calls to IdC. This region is provided to the Lambda functions so they can call the IdC instance in the appropriate region. Also modified the exchangeIdPTokenForIAMSessionCreds function to use this new configured region.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

james-jory commented 1 day ago

The PR looks good to me. @james-jory Can you please confirm that you have tested the changes end to end?

Yes. I used the publish.sh script to stage the deployment assets to a bucket in my account, deployed the staged assets using the CFN link (i.e., the link for the "Launch stack" button but from my bucket), and tested the gateway authentication and functionality for a cross-region configuration.