aws-samples / amazon-sagemaker-codeserver

Hosting code-server on Amazon SageMaker
MIT No Attribution
51 stars 16 forks source link

Doesn't work for al2-v1 sagemaker-notebook? #29

Closed zhh210 closed 1 year ago

zhh210 commented 1 year ago

The script works on an al2-v2 sagemaker notebook instance. However, the code-server launcher button never shows up for al2-v1 instance regardless putting it in lifecycle configuration or manually install it.

giuseppeporcelli commented 1 year ago

Thanks for reporting this issue. Could you share the console outputs from the install procedure?

giuseppeporcelli commented 1 year ago

JupyterLab extension support for al2-v1 has been deprecated in release 0.2.0. As a consequence, the JupyterLab launcher button will not appear. However, you can still access code-server by typing the direct address in the browser (see the Caveats / know limitations section in the README).