search

aws-samples / amazon-sagemaker-immersion-day

MIT No Attribution
271 stars 222 forks source link

fixing column drop in build train deploy processing lab #63

Closed celmore25 closed 1 year ago

celmore25 commented 1 year ago

Issue #, if available:

Description of changes:

Cell 16 inside of the the notebook for Lab 2 (processing_xgboost.ipynb) was dropping the first column of the test_x dataframe. However, the first column is a feature which the model is expecting, not the label which is in the train and validation dataframe. This change removes the column drop which was causing the model predictions be in inaccurate.

@harryxpan first reported this bug.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

celmore25 commented 1 year ago

@icetruc91 Has reviewed and tested fixes