auto-stop-idle/autostop.py ignores open terminal sessions

[rogalski]

Bug: When JupyterLab is open, but terminal sessions are used instead of notebook sessions, instance may get incorrectly shut down despite being actively used.

Debug:

1. autostop.py uses sessions API: https://github.com/aws-samples/amazon-sagemaker-notebook-instance-lifecycle-config-samples/blob/master/scripts/auto-stop-idle/autostop.py#L88
2. Jupyter exposes info about notebooks and terminals under separate APIs:
   • https://jupyter-server.readthedocs.io/en/latest/developers/rest-api.html#get--api-sessions-session for notebook sessions
   • https://jupyter-server.readthedocs.io/en/latest/developers/rest-api.html#get--api-terminals-terminal_id for terminals
3. Activity on terminal never gets picked up by autostop.py which may result in premature shutdown

Caveats:

• Newer Jupyter versions expose last activity timestamp in terminal API
• Version available currently in AWS od not expose this information

From my manual check 5 minutes ago:

sh-4.2$ curl -k https://localhost:8443/api/terminals/1
{"name": "1"}sh-4.2$

[nethraui]

Do you have any fix for this?

[rvencu]

bumping up this issue

[takeru1205]

I opened PR that monitor notebook and terminal session! Please check this out!

[dmlause]

Thank you @takeru1205 - I left a comment on the PR.