Closed JuliaABurch closed 2 years ago
If I remember right, the BabylonJS Editor is only supporting English for now. Will it be a blocker of any of our language support?
Will it be a blocker of any of our language support?
This does not block any language support. This will allow customers to use this helper method with voices that support more than one language (such as Aditi, which can be used with en-IN or hi-IN.)
Description
Adding
language
as a parameter to the static helper methodHostObject.addTextToSpeech
, with a default ofen-US
-- this is somewhat arbitrary, as the core library actually specifiesen-GB
as a default language if none is specified. It ultimately checks to make sure the language is supported by the voice, and will select the voice's default language if not.So this is not a dangerous default to set -- in the sense that if we were to pass in
Mizuki
(a voice that only supports the languageja-JP
) without passing in a language as an argument to override the default, the core library will do the right thing by usingja-JP
instead of theen-US
default..Submission Checklist
I confirm that I have...
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.