Fix Build Failure for Windows - Githubissues

aws-samples / amazon-sumerian-hosts

Amazon Sumerian Hosts (Hosts) is an experimental open source project that aims to make it easy to create interactive animated 3D characters for Babylon.js, three.js, and other web 3D frameworks. It leverages AWS services including Amazon Polly (text-to-speech) and Amazon Lex (chatbot).

MIT No Attribution

174 stars 80 forks source link

Fix Build Failure for Windows #129

Closed brhook-aws closed 2 years ago

brhook-aws commented 2 years ago

Description

Fix Windows build failures by adding dependency to cross-env
Fix several minor typos throughout documentation
Auto-fix lint problem

Added Dependency

cross-env: https://www.npmjs.com/package/cross-env
- Allows for Windows, Linux, and MacOS to work properly with environment variables

Reviewer Testing

Pull down PR
Build, and start a server with the new cross-env commands
Verify it is working as expected

Submission Checklist

I confirm that I have...

[X] removed hard-coded Cognito IDs
[X] manually smoke-tested the BabylonJS integration tests
[X] manually smoke-tested the BabylonJS demos
[X] manually smoke-tested the Three.js integration tests
[X] manually smoke-tested the Three.js demo

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.