Amazon Sumerian Hosts (Hosts) is an experimental open source project that aims to make it easy to create interactive animated 3D characters for Babylon.js, three.js, and other web 3D frameworks. It leverages AWS services including Amazon Polly (text-to-speech) and Amazon Lex (chatbot).
MIT No Attribution
175
stars
80
forks
source link
Fix issue where HOSTS_VERSION was incompatible with packages not using webpack #142
We were setting the HOSTS_VERSION at build time using webpack.
We also want customers who want to use modules/not use our webpack build to be able to do so.
These are incompatible.
To solve this, we are now writing out the version number into source at release time. This should have the same effect as before, anyone using an NPM release will get a version number, otherwise you will have 'development'.
We were setting the HOSTS_VERSION at build time using webpack.
We also want customers who want to use modules/not use our webpack build to be able to do so.
These are incompatible.
To solve this, we are now writing out the version number into source at release time. This should have the same effect as before, anyone using an NPM release will get a version number, otherwise you will have 'development'.
I tested this in a release in my fork, you can see the overwritten file here in the artifacts: https://github.com/prestomation/amazon-sumerian-hosts/actions/runs/3301290701
Related Issue #133
Reviewer Testing Instructions
Can't completely test without creating a release. After this is merged we will perform a release and test our repro cases to fully test
Submission Checklist
I confirm that I have...
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.