aws-samples / amazon-sumerian-hosts

Amazon Sumerian Hosts (Hosts) is an experimental open source project that aims to make it easy to create interactive animated 3D characters for Babylon.js, three.js, and other web 3D frameworks. It leverages AWS services including Amazon Polly (text-to-speech) and Amazon Lex (chatbot).
MIT No Attribution
175 stars 80 forks source link

Fix support for neural-only voices #160

Closed Krxtopher closed 1 year ago

Krxtopher commented 1 year ago

Description

This is a bug fix. Prior to this PR, if a developer tried to configure a host to use a voice that was only supported with the Polly neural engine the voice ID would be ignored and the host would default to using the Amy (en-GB) voice.

The root cause was faulty conditional logic that didn't accurately identify when the neural engine was available. This PR fixes that.

Related Issue \

n/a

Reviewer Testing Instructions

In the previous version of the repo, if you modified any of the demos to use a neural-only voice like "Elin" it would instead use "Amy" instead. Now if you modify any of the demos to use a neural-only voice, that voice will be used.

Submission Checklist

I confirm that I have...


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.