Open trusktr opened 9 months ago
very interested in this. maybe double check "removed hard-coded Cognito IDs". good work.
At this point, ESM changes are complete, and this is representative of the new repo format in every way. We just need to apply the fix for Babylon's animation API.
very interested in this. maybe double check "removed hard-coded Cognito IDs". good work.
@theVoiceMouse Thanks! Indeed, I'll squash this, and I'll void that key and make myself a new one. :)
Description
Converts examples to JavaScript (ES) modules, and imports all libraries via
import
syntax (except forAWS
which is still a global var from a non-module script).This is WIP, all examples and integration tests load, but Babylon demos have a break from Babylon 5 (see below). We also need to
webpack.config.js
because we're not building the source anymore (unless we still need them for Karma unit tests)start-*
scripts so they open a particular example's folder (similar to what webpack dev server was doing)import
them, but it breaks the character animations, which we will need to fix:Related Issue \
Reviewer Testing Instructions
npm install
npx live-server .
at the root of the repo to start a static web server,Submission Checklist
I confirm that I have...
This contribution is licensed under the original MIT-0 license of the repository. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.