aws-samples / amazon-sumerian-hosts

Amazon Sumerian Hosts (Hosts) is an experimental open source project that aims to make it easy to create interactive animated 3D characters for Babylon.js, three.js, and other web 3D frameworks. It leverages AWS services including Amazon Polly (text-to-speech) and Amazon Lex (chatbot).
MIT No Attribution
175 stars 80 forks source link

Fix missing babylon types #190

Open trusktr opened 4 months ago

trusktr commented 4 months ago

[!Note] This is branched off of the branch for

  • 183

See that PR first. For convenience, here's the diff between the branches, as the Files changed tab will not be useful.

Description

Babylone.js types were not visible within the Babylon host code.

Before:

Screenshot 2024-02-16 at 9 46 37 PM

After:

Screenshot 2024-02-16 at 9 47 34 PM

Related Issue \

Reviewer Testing Instructions

Run npm install && npm run compile-ts at the root of the repo. Then open packages/amazon-sumerian-hosts-babylon/src/Babylon.js/HostObject.js and hover on Babylon APIs and you will see helpful tooltips showing types.

Submission Checklist

I confirm that I have...


This contribution is licensed under the original MIT-0 license of the repository. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.