aws-samples / amazon-sumerian-hosts

Amazon Sumerian Hosts (Hosts) is an experimental open source project that aims to make it easy to create interactive animated 3D characters for Babylon.js, three.js, and other web 3D frameworks. It leverages AWS services including Amazon Polly (text-to-speech) and Amazon Lex (chatbot).
MIT No Attribution
183 stars 82 forks source link

Add CodeQL to Action workflows. #86

Closed prestomation closed 2 years ago

prestomation commented 2 years ago

This change adds the default CodeQL analysis to our PR workflow.

It also turns on our default workflow to run on pushes. As a side-effect, this will ensure the build is ran if someone pushes directly to the repo with a PR, but the primary purpose is to configure CodeQL to run against the branch itself, and not just a PR. This is necessary for CodeQL to detect risk changes.

This PR will fail the CodeQL check due to some regex problems in the compiled docs output.

I have tested in my forked repo, and if we merge this anyway, then these alerts stick around in the Security tab in github, but subsequent PRs will not fail as CodeQL will recognize that we previously accepted these risks.

We need to figure out what to do with the doc site and fix it up, but I wanted to get this in so we get immediate feedback as we continue to write core code in this repo

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.