aws-samples / amazon-textract-response-parser

Parse JSON response of Amazon Textract
Apache License 2.0
218 stars 95 forks source link

Fix TRP.js undefined imports in front-end toolchains #149

Closed athewsey closed 1 year ago

athewsey commented 1 year ago

Issue #, if available: #139

Description of changes:

While IIFE is appropriate for direct-to-browser use with CDNs like jsDelivr and UNPKG, front end frameworks like webpack also refer to this browser field - but they should use standard CommonJS build instead to import the library correctly.

Testing done:

This change can be conveniently tested in user code via published NPM version v0.2.2-alpha.1.

From my side, verified that:

Next steps:

Ideally we can get fix confirmation from the issue author, then publish mainline 0.2.2 release, rebase the fix branch, and merge.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.