aws-samples / amazon-textract-response-parser

Parse JSON response of Amazon Textract
Apache License 2.0
218 stars 95 forks source link

(src-js) `ApiBlock` types are missing the `Page` property of type `number` #170

Open rob3c opened 9 months ago

rob3c commented 9 months ago

All ApiBlock types (except ApiQueryBlock and ApiQueryResultBlock) in the javascript source are missing the Page property that's found on all blocks in the JSON response objects. The Python and C# libraries already include it, however.

athewsey commented 7 months ago

Hi @rob3c, my initial observations on this one (referring to current working version test data sets):

Tentative hypothesis that maybe this field stopped getting reported at block level some time perhaps mid 2023? ...Unless you're still seeing it in more recent API results now? Or if @schadem can shed any more light on it.

Definitely agree it looks worth adding to the type model in some capacity, but e.g. maybe if it's disappeared already we can explicitly mark it as such in the JSDoc, and not attach it to block types for features that came out after it went away.