aws-samples / amazon-transcribe-live-meeting-assistant

MIT No Attribution
73 stars 24 forks source link

We would like to specify a language code other than en-US for the speech recognition in the virtual-participant functionality. #117

Closed t-narita1112 closed 1 month ago

t-narita1112 commented 1 month ago

Is your feature request related to a problem? Please describe. This issue is related to the virtual-participant functionality. It seems that the language for speech-to-text is hardcoded to en-US, and the language specified in the CloudFormation parameters is not being used.

Describe the solution you'd like We would like to use the "TRANSCRIBE_LANGUAGE_CODE" set in the ECS task environment variables for the language code.

Describe alternatives you've considered We are not considering any other options at this time.

Additional context I will add further details in the comments once I create the pull request.

t-narita1112 commented 1 month ago

I have created the pull request. https://github.com/aws-samples/amazon-transcribe-live-meeting-assistant/pull/118

rstrahan commented 1 month ago

Thanks @t-narita1112 ! I have added review comments to your PR. Look forward to hearing back, and hopefully we can include this in the next release.

t-narita1112 commented 1 month ago

@rstrahan Thank you for your comments on the PR! I have pushed the updated source code. Please take a look.

rstrahan commented 1 month ago

Released in v0.2.2