search

aws-samples / ams-self-service-reporting-aggregator

MIT No Attribution
4 stars 1 forks source link

Added aggregation of AMS Weekly Incident Reports #3

Closed msalheb closed 1 year ago

msalheb commented 1 year ago

Description of changes:

Per our discussion, a customer I am working with wanted to aggregate AMS Weekly Incident Reports. This pull request aggregates those reports in the same way as the existing patch and backup reports in the current solution, but the refresh schedule for Weekly Incident Reports is weekly rather than daily. Also fixed the mapping of the schedule parameter for instance details.

jetennan commented 1 year ago

Thanks @msalheb reviewing and testing now

jetennan commented 1 year ago

Also fixed the mapping of the schedule parameter for instance details.

Nice pickup, thanks!

jetennan commented 1 year ago

This is a great feature, I have tested, and it works well! I can see your code aligns with all existing conventions and permissions, and that the crawler aligns with the weekly frequency of the report.

Thank you for your contribution.