aws-samples / automate-cross-account-cicd-cfn-cdk

MIT No Attribution
70 stars 24 forks source link

Codepipeline action correction #5

Closed lobobinario closed 2 years ago

lobobinario commented 2 years ago

As long we specificy both, role and deployment_role in CloudFormationCreateUpdateStackAction pipeline action we don't need to set adminPermissions to true.

Issue #, if available:

*Description of changes: set adminPermissions to false in codepipeline cloudformation deployment action

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

natalie-white-aws commented 2 years ago

You're right, great catch! Silly me.