AWS Ambit Scenario Designer for Unreal Engine 4 (Ambit) is a suite of tools to streamline content creation at scale for autonomous vehicle and robotics simulation applications.
The Ambit code base is missing a consistent style in certain areas. This causes a confusion on some of the styling of what the entirety the code base is supposed to follow.
What was the solution? (How)
ReSharper cleanup was ran against the entire code base, I used spot checking to ensure that the code worked correctly.
A few manual changes were used with this commit:
Adding space after "pragma once" line
AmbitModule.cpp was missing the initial "Ambit" directory, so was added for consistency
A rare double-space after last include
Two cases in the same file where the single-line If was not reformatted with parenthesis correctly
A few places were corrected against the ReSharper formatting:
Any places where a "= default;" was put on a new line (this was ~80% of total new "= default;" additions) were moved to the same line as declaration
A few places had changed parameters to const & which caused issued for UE native delegates, and were reverted
"Super" was removed from some of the Ambit Spawners, but was required for their function to behave properly so was reverted
One case where the metadata tag for glTF put a semicolon on a new line incorrectly, so it was placed on the previous line
One case where "const const" was used for an auto variable, the first "const" was removed
Any non-lambda declaration that had an unnamed parameter was added as /*paramName*/ were changed to just be the paramName instead
Commit (91b55ffa77fb1516fd6eba94f3a4532d3ab80950)
Re-ran with removing existing line breaks
Removed Slate Modifications that impacted indentation
Adding formatter off/on around Slate code
Reverted EMatchBy enum specifiers
Various minor formatting changes based on what Cleanup outputted
What artifacts are related to this change?
Issues: P55843926
What is the impact of this change?
This change impacts users of the repository to set up a consistent style throughout the code base.
Are you adding any new dependencies to the system?
No.
How were these changes tested?
Spot checking files for correctness
Code was compiled
Unit tests were ran and passed successfully
Creating SDF
Creating BSC
Entering play mode with default map
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
What was the problem/requirement? (What/Why)
The Ambit code base is missing a consistent style in certain areas. This causes a confusion on some of the styling of what the entirety the code base is supposed to follow.
What was the solution? (How)
ReSharper cleanup was ran against the entire code base, I used spot checking to ensure that the code worked correctly.
A few manual changes were used with this commit:
Ifwas not reformatted with parenthesis correctlyA few places were corrected against the ReSharper formatting:
const &which caused issued for UE native delegates, and were reverted/*paramName*/were changed to just be the paramName insteadCommit (91b55ffa77fb1516fd6eba94f3a4532d3ab80950)
What artifacts are related to this change?
Issues: P55843926
What is the impact of this change?
This change impacts users of the repository to set up a consistent style throughout the code base.
Are you adding any new dependencies to the system?
No.
How were these changes tested?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.