search

aws-samples / aws-ambit-scenario-designer-ue4

AWS Ambit Scenario Designer for Unreal Engine 4 (Ambit) is a suite of tools to streamline content creation at scale for autonomous vehicle and robotics simulation applications.
https://aws-samples.github.io/aws-ambit-scenario-designer-ue4/
Apache License 2.0
85 stars 21 forks source link

Add unit tests for export functionality #16

Closed rukekre closed 2 years ago

rukekre commented 2 years ago

What was the problem/requirement? (What/Why)

Unit tests for export map and export gltf functionality were missing.

What was the solution? (How)

Added unit tests for these features.

What artifacts are related to this change?

Issues: P52848900

What is the impact of this change?

Expands unit tests to cover more features.

Are you adding any new dependencies to the system?

No.

How were these changes tested?

Locally, following the established unit test procedure.

How does this commit make you feel? (Optional, but encouraged)

:)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

kris-work commented 2 years ago

It surprised me a little that these tests were added to the ConfigImportExport.spec.cpp file. I didn't find that intuitive. My gut tells me that file's scope has gotten a little out of control. The Single Responsibility Principle applies to unit tests, too! I don't think we have to change it for now (unless you feel like it), but take this into consideration in the future.