search

aws-samples / aws-bookstore-demo-app

AWS Bookstore Demo App is a full-stack sample web application that creates a storefront (and backend) for customers to shop for fictitious books. The entire application can be created with a single template. Built on AWS Full-Stack Template.
MIT No Attribution
623 stars 306 forks source link

Adding support for Amazon OpenSearch Service #32

Closed triggan closed 2 years ago

triggan commented 2 years ago

*Issue #, if available: https://github.com/aws-samples/aws-bookstore-demo-app/issues/31

*Description of changes: Updated stack to support Amazon OpenSearch Service. Ensured the primary stack template and the template container lambda warmers were both in-sync.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ctindel commented 2 years ago

If you're going to change the environment variables passed to the lambdas like "ES_ENDPOINT" => "OS_ENDPOINT" you have to change it in the lambdas too. Like this one:

https://github.com/aws-samples/aws-bookstore-demo-app/blob/master/functions/APIs/search.py#L14

Edit: Nevermind, I just saw that you didn't actually change those variables, I'm assuming for this reason. Maybe we should put it in the backlog so we don't forget to do it later.

The changes look good to me.