search

aws-samples / aws-cdk-examples

Example projects using the AWS CDK
Apache License 2.0
4.95k stars 2.1k forks source link

chore(csharp): update nodejs version to 20.x #1039

Closed trivikr closed 1 month ago

trivikr commented 1 month ago

Similar to https://github.com/aws-samples/aws-cdk-examples/pull/1010 Part of: https://github.com/aws-samples/aws-cdk-examples/issues/961

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

trivikr commented 1 month ago

I'm not sure why the 'Runtime' does not contain a definition for 'NODEJS_20_X' error is thrown.

The Node.js 20.x runtime was added in v2.109.0 in https://github.com/aws/aws-cdk/pull/27897 And this PR updates the aws-cdk version to v2.133.0 in csharp/package.json

kaiz-io commented 1 month ago

@trivikr It is your csproj file that controls the lib that your dotnet uses to compile. I removed your change to the csharp/package.json That file control the cdk cli version which I always want to be up to date.