search

aws-samples / aws-cdk-examples

Example projects using the AWS CDK
Apache License 2.0
5.09k stars 2.14k forks source link

Add back key pair creation for EC2 #853

Closed thvasilo closed 11 months ago

thvasilo commented 1 year ago

Describe the bug

EC2 key creation is now supported, but the EC2-instance example has removed it https://github.com/aws-samples/aws-cdk-examples/blob/d48d5319702d901fa9a0571aa4fc4d812fceb3d7/typescript/ec2-instance/lib/ec2-cdk-stack.ts#L14

Expected Behavior

The EC2 example should allow key creation

Current Behavior

The key creation has been removed from EC2 example

Reproduction Steps

https://github.com/aws-samples/aws-cdk-examples/blob/d48d5319702d901fa9a0571aa4fc4d812fceb3d7/typescript/ec2-instance/lib/ec2-cdk-stack.ts#L14

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.80.0

Framework Version

No response

Node.js Version

v18.16.0

OS

Mac OS Monterey 12.6.5

Language

Typescript

Language Version

No response

kaiz-io commented 11 months ago

Merged

github-actions[bot] commented 11 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.