search

aws-samples / aws-cdk-examples

Example projects using the AWS CDK
Apache License 2.0
4.97k stars 2.11k forks source link

build-typescript.sh should not install packages if package.json is not available #892

Closed pahud closed 11 months ago

pahud commented 11 months ago

Describe the bug

build-typescript.sh was failing due to missing package.json

https://github.com/aws-samples/aws-cdk-examples/actions/runs/5650661225/job/15307412270

Expected Behavior

should just pass if package.json is not available

Current Behavior

yarn install but failed.

Reproduction Steps

submit a PR with updates under typescript/ecs/*

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.88.0

Framework Version

No response

Node.js Version

v19

OS

mac os x

Language

Typescript

Language Version

No response

pahud commented 11 months ago

I'll submit a PR for that.

github-actions[bot] commented 11 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.