search

aws-samples / aws-cloudhsm-jce-examples

Sample applications demonstrating how to use the CloudHSM JCE
MIT No Attribution
36 stars 56 forks source link

cloudhsm maven dependency out of date #44

Closed drjerry closed 2 years ago

drjerry commented 2 years ago

Replication

  1. Successfully installed the JCE Provider.
  2. Ran ls -l /opt/cloudhsm/java/, which listed cloudhsm-3.4.0.jar, among other artifacts.
  3. Cloned the aws-cloudhsm-jce-examples repo with HEAD -> https://github.com/aws-samples/aws-cloudhsm-jce-examples/commit/62a90892459a0f6a9e231e7b790e459691167acd.
  4. Ran cd aws-cloudhsm-jce-examples && mvn validate which issued the following error: 
    [INFO] --- maven-install-plugin:2.5.1:install-file (install-cloudhsm-jce) @ aws-cloudhsm-jce-examples ---
[ERROR] The specified file '/opt/cloudhsm/java/cloudhsm-3.1.2.jar' not exists

Resolution

I was able to update the version in the pom file locally.

I am happy to issue a PR with a 1-line change if the maintainers would like; I've noticed previous PRs like this bump versions in many of the maven dependencies, not just cloudhsm.

rday commented 2 years ago

We missed this! If you are able to submit the PR I can approve. Thanks!