Invalid endpoint in badge url when region is us-east-1

aws-samples / aws-codecommit-pull-request-aws-codebuild

Validating AWS CodeCommit Pull Requests with AWS CodeBuild and AWS Lambda

MIT No Attribution

46 stars 46 forks source link

Invalid endpoint in badge url when region is us-east-1 #1

Open lorengordon opened 5 years ago

lorengordon commented 5 years ago

s3-us-east-1 is not a valid S3 endpoint.

https://github.com/aws-samples/aws-codecommit-pull-request-aws-codebuild/blob/397e07b8740ea572c65aa08e9a4ba1128d7f41e1/base-layer.yaml#L190-L197

See:

https://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region

lorengordon commented 5 years ago

Well, may be immaterial, since CodeCommit (in us-east-1) does not resolve the image links anyway.

j0lly commented 5 years ago

Hi @lorengordon thanks for reaching out with this. You right, the s3 dns naming will breaks in us-east-1, let me change that. As per your second comment, do you mind explaining what you did and what is not working?

Thanks,