search

aws-samples / aws-codecommit-serverless-backup

A serverless solution to back up CodeCommit repositories to S3
MIT No Attribution
47 stars 60 forks source link

Typo in policyname lambdaexecute #4

Open sgzijl opened 6 years ago

sgzijl commented 6 years ago

I found a typo in the lambda execute role at line 61:

https://github.com/aws-samples/aws-codecommit-serverless-backup/blob/72e099d2c7918d87da8b6d169610387b6a0d0948/codecommit_backup_cfn_template.yaml#L61

Please, replace GPutbject with PutObject.

// Siert

ruanxuyi commented 4 years ago

Noticed the same thing lol... also worth to noted that Lambda IAM role should not need any access to S3 at all. it only need access for CodeBuild:start. Should remove s3 permission entirely.