The documentation is wrong about ELB_LIST

aws-samples / aws-codedeploy-samples

Samples and template scenarios for AWS CodeDeploy

Apache License 2.0

636 stars 782 forks source link

The documentation is wrong about ELB_LIST #38

Open techgnosis opened 8 years ago

techgnosis commented 8 years ago

You don't need to edit ELB_LIST anymore. There is a method in common_functions.sh that populates it for you.

johnwheal commented 8 years ago

Thanks, you saved me a lot of time by posting this - AWS should probably update the docs

nwalke commented 8 years ago

Correct me if I'm wrong... but we still need to manually call this from somewhere, right?

techgnosis commented 8 years ago

You need to call the register/deregister scripts but you don't need to set ELB_LIST before you do it On Apr 25, 2016 7:27 AM, "Nick Walke" notifications@github.com wrote:

Correct me if I'm wrong... but we still need to manually call this from somewhere, right?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/awslabs/aws-codedeploy-samples/issues/38#issuecomment-214359952

wjordan commented 8 years ago

To clarify:

You do not need to set ELB_LIST at all if your instances are a part of an Auto Scaling Group.
You do need to set ELB_LIST if your instances are registered with load balancer(s) manually.
The get_elb_list function in common_functions.sh will populate ELB_LIST for you. However, there are currently issues (see my PR #41 for a fix).
I've submitted a PR #40 to use get_elb_list to automatically populate ELB_LIST for you as long as you set ELB_LIST to all.