search

aws-samples / aws-cudos-framework-deployment

Command Line Interface tool for Cloud Intelligence Dashboards deployment
https://catalog.workshops.aws/awscid
MIT No Attribution
411 stars 167 forks source link

Terraform deployment not compatible with CID dashboard deployment #1029

Open nickcasscs opened 1 week ago

nickcasscs commented 1 week ago

When deploying either the CUDOS, Cost Intelligence or KPI dashboards the CID Dashboard deployment via terraform wrapper uses a cloudformation template that relies on a stack output cid-DataExport-Database from the cloudformation destination deployment. When deploying the solution using the cur-setup-destination terraform module this stack doesn't exist and as a result, the stack output also does not exist; this causes the stack deploy to fail.

By passing CurVersion = "1.0" to the cid deployment stack parameters this issue looks like it is resolved. There isn't any reference in the documentation that this stack parameter is required currently in either the Terraform deployment instructions or the README for the cid-dashboards terraform module.

It would save implementers a lot of time spent troubleshooting if this is noted in the documentation.

iakov-aws commented 6 days ago

@sean-nixon we probably need to provide terrarform wrappers for Data Exports modules as well

christrotter commented 22 hours ago

Also running into something similar. We are being advised by our TAM to go forward with CUDOS v5 and CUR 2.0, but the 'source' Terraform module provided only creates the aws_cur_report_definition resource: https://github.com/aws-samples/aws-cudos-framework-deployment/blob/main/terraform-modules/cur-setup-source/main.tf#L253

That resource is legacy and not CUR 2.0.

Rather, the resource it should be using is this:aws_bcmdataexports_export https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/bcmdataexports_export

For us to move forward, we will have to copy the source module and modify it so that it uses the correct resource. However - I think that once that issue is addressed, the rest of the provided bits and pieces should work, as all of the complicated downstream infrastructure has already been coded to support CUR 2.0.

I will report back once I have been successful!